Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace _.assign and _.extend with Object.assign #7766

Merged
merged 2 commits into from May 26, 2020

Conversation

hellovietduc
Copy link

Related issue: #7747

@codecov-commenter
Copy link

codecov-commenter commented May 22, 2020

Codecov Report

Merging #7766 into master will not change coverage.
The diff coverage is 95.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7766   +/-   ##
=======================================
  Coverage   88.11%   88.11%           
=======================================
  Files         246      246           
  Lines        9279     9279           
=======================================
  Hits         8176     8176           
  Misses       1103     1103           
Impacted Files Coverage Δ
lib/plugins/aws/provider/awsProvider.js 92.72% <ø> (ø)
...ompile/events/apiGateway/lib/method/integration.js 98.21% <85.71%> (ø)
lib/classes/PluginManager.js 96.67% <100.00%> (ø)
lib/classes/Variables.js 99.72% <100.00%> (ø)
lib/plugins/aws/deploy/lib/createStack.js 100.00% <100.00%> (ø)
lib/plugins/aws/deploy/lib/extendedValidate.js 97.56% <100.00%> (ø)
lib/plugins/aws/lib/updateStack.js 98.24% <100.00%> (ø)
...ckage/compile/events/apiGateway/lib/authorizers.js 100.00% <100.00%> (ø)
.../package/compile/events/apiGateway/lib/validate.js 96.98% <100.00%> (ø)
lib/plugins/aws/package/compile/events/s3/index.js 100.00% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a60d2c7...08e59ab. Read the comment docs.

@hellovietduc hellovietduc changed the title Replace _.assign with Object.assign Replace _.assign and _.extend with Object.assign May 22, 2020
Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vietduc01100001 Looks great!

@medikoo medikoo merged commit 85e9cd4 into serverless:master May 26, 2020
@exoego exoego mentioned this pull request May 26, 2020
54 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants