Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(lodash): Replace _.filter with array.filter #7775

Merged
merged 1 commit into from May 26, 2020
Merged

refactor(lodash): Replace _.filter with array.filter #7775

merged 1 commit into from May 26, 2020

Conversation

rmidhun23
Copy link
Contributor

@rmidhun23 rmidhun23 commented May 25, 2020

Addresses: #7747

@codecov-commenter
Copy link

Codecov Report

Merging #7775 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7775   +/-   ##
=======================================
  Coverage   88.11%   88.11%           
=======================================
  Files         246      246           
  Lines        9279     9281    +2     
=======================================
+ Hits         8176     8178    +2     
  Misses       1103     1103           
Impacted Files Coverage Δ
...ws/package/compile/events/cognitoUserPool/index.js 100.00% <100.00%> (ø)
lib/plugins/package/lib/zipService.js 94.64% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a60d2c7...026dd1c. Read the comment docs.

Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @rmidhun23 Looks great!

@medikoo medikoo merged commit dac7c56 into serverless:master May 26, 2020
@exoego exoego mentioned this pull request May 26, 2020
54 tasks
@rmidhun23
Copy link
Contributor Author

@medikoo Appreciate the prompt review.

@rmidhun23 rmidhun23 deleted the refactor/lodash-deps-concat branch May 26, 2020 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants