Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace lodash _.find with native Array.find #7782

Conversation

chrisVillanueva
Copy link
Contributor

@chrisVillanueva chrisVillanueva commented May 27, 2020

Addresses: #7747

@codecov-commenter
Copy link

codecov-commenter commented May 27, 2020

Codecov Report

Merging #7782 into master will decrease coverage by 0.01%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7782      +/-   ##
==========================================
- Coverage   88.21%   88.20%   -0.02%     
==========================================
  Files         245      245              
  Lines        9302     9302              
==========================================
- Hits         8206     8205       -1     
- Misses       1096     1097       +1     
Impacted Files Coverage Δ
lib/plugins/aws/deploy/lib/createStack.js 97.29% <50.00%> (-2.71%) ⬇️
lib/classes/Utils.js 95.33% <100.00%> (ø)
...package/compile/events/apiGateway/lib/resources.js 97.47% <100.00%> (ø)
...ib/plugins/aws/package/compile/events/sns/index.js 93.40% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4074739...4211880. Read the comment docs.

Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chrisVillanueva looks great, thank you!

I've just proposed few minor improvements, where actually some should be used instead

lib/plugins/aws/deploy/lib/createStack.js Outdated Show resolved Hide resolved
lib/plugins/aws/package/compile/events/sns/index.js Outdated Show resolved Hide resolved
Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @chrisVillanueva !

@medikoo medikoo merged commit 0036962 into serverless:master Jun 2, 2020
@exoego exoego mentioned this pull request Jun 2, 2020
54 tasks
@chrisVillanueva chrisVillanueva deleted the contribute/lodash-find-to-array-find branch June 2, 2020 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants