New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace lodash _.find with native Array.find #7782
Replace lodash _.find with native Array.find #7782
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7782 +/- ##
==========================================
- Coverage 88.21% 88.20% -0.02%
==========================================
Files 245 245
Lines 9302 9302
==========================================
- Hits 8206 8205 -1
- Misses 1096 1097 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chrisVillanueva looks great, thank you!
I've just proposed few minor improvements, where actually some
should be used instead
….com/chrisVillanueva/serverless into contribute/lodash-find-to-array-find
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @chrisVillanueva !
Addresses: #7747