Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace lodash _.keys with native Object.keys #7784

Conversation

chrisVillanueva
Copy link
Contributor

@chrisVillanueva chrisVillanueva commented May 27, 2020

Addresses: #7747

@codecov-commenter
Copy link

Codecov Report

Merging #7784 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7784   +/-   ##
=======================================
  Coverage   88.13%   88.13%           
=======================================
  Files         245      245           
  Lines        9262     9262           
=======================================
  Hits         8163     8163           
  Misses       1099     1099           
Impacted Files Coverage Δ
...s/package/compile/events/apiGateway/lib/apiKeys.js 94.59% <100.00%> (ø)
...package/compile/events/apiGateway/lib/resources.js 97.47% <100.00%> (ø)
lib/plugins/aws/package/compile/functions/index.js 96.73% <100.00%> (ø)
...ib/plugins/aws/package/lib/generateCoreTemplate.js 95.45% <100.00%> (ø)
lib/plugins/package/lib/zipService.js 94.64% <100.00%> (ø)
lib/utils/yamlAstParser.js 97.32% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af3fbf0...dbe3afd. Read the comment docs.

Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @chrisVillanueva !

@medikoo medikoo merged commit d43241e into serverless:master May 28, 2020
@exoego exoego mentioned this pull request May 28, 2020
54 tasks
@chrisVillanueva chrisVillanueva deleted the contribute/lodash-keys-to-object-keys branch May 28, 2020 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants