Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace lodash _.size with native array length & object.keys length #7798

Merged
merged 2 commits into from Jun 1, 2020
Merged

Replace lodash _.size with native array length & object.keys length #7798

merged 2 commits into from Jun 1, 2020

Conversation

chrisVillanueva
Copy link
Contributor

@chrisVillanueva chrisVillanueva commented May 30, 2020 •
edited by medikoo

Addresses: #7747

@codecov-commenter
Copy link

Codecov Report

Merging #7798 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7798   +/-   ##
=======================================
  Coverage   88.15%   88.15%           
=======================================
  Files         245      245           
  Lines        9267     9267           
=======================================
  Hits         8169     8169           
  Misses       1098     1098
Impacted Files Coverage Δ
lib/classes/Utils.js 95.27% <100.00%> (ø)
.../compile/events/apiGateway/lib/hack/updateStage.js 95.12% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e0af21...dac2de2. Read the comment docs.

medikoo
medikoo approved these changes Jun 1, 2020
View reviewed changes
Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @chrisVillanueva !

@medikoo medikoo merged commit 2b00928 into serverless:master Jun 1, 2020
@exoego exoego mentioned this pull request Jun 1, 2020
Open
54 tasks
@chrisVillanueva chrisVillanueva deleted the contribute/lodash-size-to-array-length-object-keys-length branch June 2, 2020 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medikoo medikoo medikoo approved these changes

Assignees
No one assigned
Labels
cat/dependency refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chrisVillanueva @codecov-commenter @medikoo