Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace lodash _.join with native array.join #7805

Merged
merged 1 commit into from Jun 3, 2020
Merged

Replace lodash _.join with native array.join #7805

merged 1 commit into from Jun 3, 2020

Conversation

chrisVillanueva
Copy link

@chrisVillanueva chrisVillanueva commented Jun 2, 2020 •
edited by medikoo

Addresses: #7747

medikoo
medikoo approved these changes Jun 3, 2020
View reviewed changes
Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @chrisVillanueva, looks great!

@medikoo medikoo merged commit 5cf46bf into serverless:master Jun 3, 2020
@exoego exoego mentioned this pull request Jun 3, 2020
Open
54 tasks
@chrisVillanueva chrisVillanueva deleted the contribute/lodash-join-to-array-join branch June 3, 2020 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medikoo medikoo medikoo approved these changes

Assignees
No one assigned
Labels
cat/dependency refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chrisVillanueva @medikoo