Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace lodash _.first with native array[0] #7816

Conversation

chrisVillanueva
Copy link

@chrisVillanueva chrisVillanueva commented Jun 4, 2020

Addresses: #7747

@codecov-commenter
Copy link

Codecov Report

Merging #7816 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7816   +/-   ##
=======================================
  Coverage   88.21%   88.21%           
=======================================
  Files         245      245           
  Lines        9307     9307           
=======================================
  Hits         8210     8210           
  Misses       1097     1097           
Impacted Files Coverage Δ
...s/package/compile/events/apiGateway/lib/apiKeys.js 94.73% <100.00%> (ø)
...age/compile/events/apiGateway/lib/usagePlanKeys.js 97.05% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e39cdfd...fb76ba2. Read the comment docs.

Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @chrisVillanueva looks great!

@medikoo medikoo merged commit a527744 into serverless:master Jun 8, 2020
@exoego exoego mentioned this pull request Jun 8, 2020
54 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants