Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile layer path invalid on win32 #7936

Closed
wants to merge 3 commits into from

Conversation

leogono
Copy link

@leogono leogono commented Jul 14, 2020

Related issue: #7489

I had the same issue on Windows 10. I saw that no one created a PR yet. But credits should go to @stevebaldwinelectroneum

Closes: #7489

Related issue: serverless#7489

I had the same issue on Windows 10. I saw that no one created a PR yet. But credits should go to @stevebaldwinelectroneum
@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2020

Codecov Report

Merging #7936 into master will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7936   +/-   ##
=======================================
  Coverage   88.29%   88.29%           
=======================================
  Files         245      245           
  Lines        9104     9104           
=======================================
  Hits         8038     8038           
  Misses       1066     1066           
Impacted Files Coverage Δ
lib/plugins/aws/invokeLocal/index.js 72.27% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e437df8...9e6c386. Read the comment docs.

Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leogono great thanks for addressing that! Can you just ensure that proposed changes respect Prettier formatting (note that CI failed)

@leogono
Copy link
Author

leogono commented Jul 15, 2020

yep, will do. :)

@leogono
Copy link
Author

leogono commented Jul 15, 2020

weird, still getting formatting issue on check. But it work out well locally.
image

@medikoo
Copy link
Contributor

medikoo commented Jul 15, 2020

@leogono for prettier-check:updated, your master needs to be in sync with this repo. Maybe there's some issue with that.

You may also confirm by checking all files (not just updated) via npm run prettier-check.

Still, CI clearly says:

ib/plugins/aws/invokeLocal/index.js
Code style issues found in the above file(s). Forgot to run Prettier?
`prettier -c lib/plugins/aws/invokeLocal/index.js`

@medikoo
Copy link
Contributor

medikoo commented Sep 22, 2020

Closing, as it was addressed with #8273

@medikoo medikoo closed this Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dockerfile layer path invalid
3 participants