fix(Config Schema): validate resourcePolicy is array

[glb]

In the AWS provider, the resourcePolicy must be an array. If you paste a resource policy from the console, your stack will fail to create.

Closes: #7795
Addresses: #8018

[glb]

I don't love that the test takes so long to run but I don't know a faster way to do it; based on tests in #7335. If there is a better way to test this I'd be happy to make the change.

[codecov-commenter]

Codecov Report

Merging #8051 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #8051      +/-   ##
==========================================
+ Coverage   88.36%   88.37%   +0.01%     
==========================================
  Files         248      248              
  Lines        9446     9446              
==========================================
+ Hits         8347     8348       +1     
+ Misses       1099     1098       -1     

Impacted Files	Coverage Δ
lib/plugins/aws/provider/awsProvider.js	92.77% <ø> (ø)
lib/classes/ConfigSchemaHandler/index.js	93.02% <0.00%> (+1.16%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4660acd...f8c1f28. Read the comment docs.

[medikoo]

@glb Great thanks for that!

Still please see my comment about testing, I think value of such tests is neglible, while maintanance cost becomes significant

[glb]

Thanks @medikoo ! I have updated, rebased, and done manual testing with invalid and valid values for resourcePolicy:

serverless.yml

service: test

provider:
  name: aws
  resourcePolicy:
    - test

Output:

Serverless: Configuration error at 'provider.resourcePolicy[0]': should be object

serverless.yml

service: test

provider:
  name: aws
  resourcePolicy: {}

Output:

Serverless: Configuration error at 'provider.resourcePolicy': should be array

serverless.yml

service: test

provider:
  name: aws
  resourcePolicy: 
  - Effect: Allow
    Principal: "*"
    Action: "*"
    Resource: "*"

Output: no error (though arguably that's a terrible resource policy. 😆 )

[medikoo]

Thank you @glb !