Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix lambda logical version id for layers in same stack #8066
Fix lambda logical version id for layers in same stack #8066
Changes from 40 commits
3e6fa90
34b0877
91e3077
f927470
f93b1aa
b4ee79a
3a01dc9
b51b81e
6d412bc
b5cb580
3080dd3
14de011
001f440
8678062
619050c
781aa98
a6ccbac
3ad5651
bccd773
997c0f0
8df8aac
a6ec21d
8b21863
18e6b1f
231cf14
4941a15
62cd779
625aea8
d7704ec
b1571c3
9ee00b4
38c867e
ff09d04
6e0be19
193c516
7ad4818
9e08cf5
c8be293
eee300e
76bf822
a9baf17
6967213
b3cea34
7c3ac73
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we're on v2 we can safely rely on async/await and native promises, so now we can construct it way more simply as:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we refactor that one, to form as proposed in above comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had refactored but I'd forgotten to remove the old logic... it should be fixed now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's use
Object.entries
instead of_.entries
(as in a meantime we've dropped support for Node.js v8)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's use native
Promise
, and for consistency let's useresolve
name insteadcb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should name property
name
. Firstly in this contextserverlessLayer
prefix is not justified, and when processing it, in one place we assume it's name (serverless/lib/plugins/aws/package/compile/functions/index.js
Line 419 in 76bf822
undefined
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, good catch. I think it must have been
name
at one point, so I've changed it back. I've added the other improvements and merged in this change from master (1fceb89) so let me know me if anything looks wrong with that.