Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(dependency): upgrade to boxen@v4.2.0 #8163

Merged
merged 1 commit into from Sep 2, 2020

Conversation

crash7
Copy link
Contributor

@crash7 crash7 commented Sep 1, 2020

Validated the breaking changes introduced in https://github.com/sindresorhus/boxen/releases/tag/v4.0.0 and they don't affect serverless@v2.

Addresses: #7486

@crash7
Copy link
Contributor Author

crash7 commented Sep 1, 2020

@medikoo not sure about this test error:

1) HttpApiEvents
       Should not configure HTTP when events are not configured:
     ServerlessError: The Serverless version (2.0.0-pre) does not satisfy the "frameworkVersion" (*) in serverless.json
      at Service.loadServiceFileParam (lib/classes/Service.js:76:13)
      at /home/runner/work/serverless/serverless/lib/classes/Service.js:53:26
  From previous event:
      at Service.load (lib/classes/Service.js:53:8)
      at /home/runner/work/serverless/serverless/lib/Serverless.js:98:29
      at processImmediate (internal/timers.js:456:21)
  From previous event:
      at Serverless.init (lib/Serverless.js:77:8)
      at /home/runner/work/serverless/serverless/node_modules/@serverless/test/run-serverless.js:179:43

Not sure if it's something already in v2 or that boxed updated a transitive dependency that triggered this.
Any idea? I will keep digging.

@serverless serverless deleted a comment from rkj1980 Sep 1, 2020
Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, that looks good!

Unfortunately CI got broken by issue that was exposed by dependency update.
It was fixed with #8166 and already propagated to v2

Can you update your branch so it's picked?

@codecov-commenter
Copy link

Codecov Report

Merging #8163 into v2 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##               v2    #8163   +/-   ##
=======================================
  Coverage   88.21%   88.21%           
=======================================
  Files         248      248           
  Lines        9408     9408           
=======================================
  Hits         8299     8299           
  Misses       1109     1109           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd3b254...52510ed. Read the comment docs.

Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @crash7 !

@medikoo medikoo merged commit 4bd2c23 into serverless:v2 Sep 2, 2020
@medikoo medikoo mentioned this pull request Sep 2, 2020
3 tasks
medikoo pushed a commit that referenced this pull request Sep 10, 2020
medikoo pushed a commit that referenced this pull request Sep 10, 2020
medikoo pushed a commit that referenced this pull request Sep 10, 2020
medikoo pushed a commit that referenced this pull request Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants