New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(dependency): upgrade to boxen@v4.2.0 #8163
Conversation
@medikoo not sure about this test error:
Not sure if it's something already in v2 or that boxed updated a transitive dependency that triggered this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, that looks good!
Unfortunately CI got broken by issue that was exposed by dependency update.
It was fixed with #8166 and already propagated to v2
Can you update your branch so it's picked?
79f5ebe
to
52510ed
Compare
Codecov Report
@@ Coverage Diff @@
## v2 #8163 +/- ##
=======================================
Coverage 88.21% 88.21%
=======================================
Files 248 248
Lines 9408 9408
=======================================
Hits 8299 8299
Misses 1109 1109 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @crash7 !
Validated the breaking changes introduced in https://github.com/sindresorhus/boxen/releases/tag/v4.0.0 and they don't affect
serverless@v2
.Addresses: #7486