Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DX: Throw if missing RoleName in Custom function role #8219

Merged
merged 3 commits into from Oct 7, 2020
Merged

DX: Throw if missing RoleName in Custom function role #8219

merged 3 commits into from Oct 7, 2020

Commits on Sep 10, 2020

  1. Throw if missing role name 

    If rolename missing this passes through `undefined` and single `sls deploy -f funcNames` fail

```
Serverless: [AWS lambda 400 0.417s 0 retries] updateFunctionConfiguration({
  FunctionName: 'service-dev-addNewUser',
  Description: 'Add user test function. Gated by imported Managed policy',
  Handler: 'examples/new-user.handler',
  Role: 'arn:aws:iam::01200101001:role/undefined'
})
```
    @DavidWells
    DavidWells committed Sep 10, 2020
    Copy the full SHA
    ba76541 View commit details
    Browse the repository at this point in the history

  2. maybe fix lint? I'm in Github UI

    @DavidWells
    DavidWells committed Sep 10, 2020
    Copy the full SHA
    db08289 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2020

  1. use this.serverless.classes.Error

    @DavidWells
    DavidWells committed Sep 26, 2020
    Copy the full SHA
    8bfc5ba View commit details
    Browse the repository at this point in the history