Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aws cloudfront event schema #8250

Merged
merged 13 commits into from Sep 22, 2020
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
18 changes: 13 additions & 5 deletions lib/plugins/aws/package/compile/events/cloudFront/index.js
Expand Up @@ -27,9 +27,21 @@ class AwsCompileCloudFrontEvents {
'before:remove:remove': this.logRemoveReminder.bind(this),
};

// TODO: Complete schema, see https://github.com/serverless/serverless/issues/8025
this.serverless.configSchemaHandler.defineFunctionEvent('aws', 'cloudFront', {
type: 'object',
properties: {
eventType: {
type: 'string',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove type here

enum: ['viewer-request', 'origin-request', 'origin-response', 'viewer-response'],
},
pathPattern: { type: 'string', pattern: '^([A-Za-z0-9-_.*$/~"\'@:+]|&)+$' },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

- char needs to be escaped (otherwise in [] it implies a range between characters.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved it to the end of the array like we do in other patterns

medikoo marked this conversation as resolved.
Show resolved Hide resolved
origin: {
oneOf: [{ type: 'string', format: 'uri' }, { type: 'object' }],
},
isDefaultOrigin: { type: 'boolean' },
includeBody: { type: 'boolean' },
behavior: { type: 'object' },
medikoo marked this conversation as resolved.
Show resolved Hide resolved
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add additionalProperties: false

});
}

Expand Down Expand Up @@ -156,10 +168,6 @@ class AwsCompileCloudFrontEvents {
if (functionObj.events) {
functionObj.events.forEach(event => {
if (event.cloudFront) {
if (!_.isObject(event.cloudFront)) {
throw new Error('cloudFront event has to be an object');
}

const lambdaFunctionLogicalId = Object.keys(Resources).find(
key =>
Resources[key].Type === 'AWS::Lambda::Function' &&
Expand Down
26 changes: 0 additions & 26 deletions lib/plugins/aws/package/compile/events/cloudFront/index.test.js
Expand Up @@ -351,32 +351,6 @@ describe('AwsCompileCloudFrontEvents', () => {
});

describe('#compileCloudFrontEvents()', () => {
it('should throw an error if cloudFront event type is not an object', () => {
awsCompileCloudFrontEvents.serverless.service.functions = {
first: {
events: [
{
cloudFront: 42,
},
],
},
};

expect(() => awsCompileCloudFrontEvents.compileCloudFrontEvents()).to.throw(Error);

awsCompileCloudFrontEvents.serverless.service.functions = {
first: {
events: [
{
cloudFront: 'some',
},
],
},
};

expect(() => awsCompileCloudFrontEvents.compileCloudFrontEvents()).to.throw(Error);
});

it('should throw an error if the region is not us-east-1', () => {
options.region = 'eu-central-1';
awsCompileCloudFrontEvents.serverless.service.functions = {
Expand Down