fix(Config Schema): Expand allowable types for vpc config #8283
Conversation
|
Added |
Codecov Report
@@ Coverage Diff @@
## master #8283 +/- ##
==========================================
- Coverage 88.19% 88.18% -0.01%
==========================================
Files 250 250
Lines 9400 9398 -2
==========================================
- Hits 8290 8288 -2
Misses 1110 1110
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
@devpow112 great thanks for that! Still I proposed simpler approach, let me know what you think
| awsLambdaVpcConfigItems: { | ||
| oneOf: [ | ||
| { type: 'string' }, | ||
| { $ref: '#/definitions/awsCfRef' }, | ||
| { $ref: '#/definitions/awsCfJoin' }, | ||
| { $ref: '#/definitions/awsCfSub' }, | ||
| { $ref: '#/definitions/awsCfImport' }, | ||
| ], | ||
| }, |
There was a problem hiding this comment.
Technically it differs from awsCfInstruction, only by fact of not including support for Fn::GetAtt, it feels dubious and it doesn't feel as VPC config specific.
I think maintaince wise it'll be better to just rely on awsCfInstruction, also I think we can't be 100% sure, that there's no use case, where Fn::GetAtt can be used for VPC resolution (although I agree, it feels unlikely)
There was a problem hiding this comment.
Fair enough. I'll switch it to use the awsCfInstruction
This enables the use of Ref, Fn::Join, Fn::Sub, Fn::Import and Fn::GetAtt when defining the vpc.subnetIds and vpc.securityGroupIds.
This enables the use of
Ref,Fn::Join,Fn::Sub,Fn::ImportandFn::GetAttwhen defining thevpc.subnetIdsandvpc.securityGroupIdsCloses: #8282