Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config Schema: Fix SNS event schema (allow both arn and topicName in sns event) #8331

Merged
merged 1 commit into from Oct 2, 2020

Conversation

medikoo
Copy link
Contributor

@medikoo medikoo commented Oct 2, 2020

Fixes regression introduced with #8323

There are valid scenarios where arn and topicName should be provided

@codecov-commenter
Copy link

Codecov Report

Merging #8331 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8331   +/-   ##
=======================================
  Coverage   88.01%   88.01%           
=======================================
  Files         249      249           
  Lines        9307     9307           
=======================================
  Hits         8192     8192           
  Misses       1115     1115           
Impacted Files Coverage Δ
...ib/plugins/aws/package/compile/events/sns/index.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a020a4a...8b92619. Read the comment docs.

@medikoo medikoo merged commit c27f5b3 into master Oct 2, 2020
@medikoo medikoo deleted the 1002-fix-sns-schema-regression branch October 2, 2020 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants