New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added awsRequest for aws-sdk call backoff and retry in customResources #8338
Merged
Merged
Changes from 13 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
a025816
added awsRequest for aws-sdk call backoff and retry in customResources
pratik-vii 49b9f15
update for prettier
pratik-vii cbafc9c
using existing env variable SLS_AWS_REQUEST_MAX_RETRIES
pratik-vii 8f0b61d
added functionality to resolve aws service instance in awsRequest
pratik-vii 2c43a32
integrated awsRequest with s3 custom resource
pratik-vii 53d52aa
integrated awsRequest with Event Bridge custom resource
pratik-vii 0a0725b
Merge branch 'master' of https://github.com/serverless/serverless int…
pratik-vii d2afc2c
integrated awsRequest with CognitoUserPool custom resource
pratik-vii 8a4523b
integrated awsRequest with APIGatewayCloudWatchRole custom resource
pratik-vii ff2a285
fix case of APIGateway for awsRequest in APIGatewayCloudWatchRole cus…
pratik-vii 3d1a697
fix case of APIGateway for awsRequest in APIGatewayCloudWatchRole cus…
pratik-vii ae40f38
removed lodash dependency
pratik-vii 5875539
changed awsRequest to async and removed unnecessary promise
pratik-vii 803324d
reverted changes of try/catch for APIGateway update account
pratik-vii 646043c
Merge branch 'master' of https://github.com/serverless/serverless int…
pratik-vii ea0863f
added async/await for awsRequest
pratik-vii File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to keep that try/catch, as in this case we want to catch also non-retryable errors, while
awsRequest
retries only if error is retryable