Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config Schema: Ensure to preserve null values for config validation #8353

Merged
merged 2 commits into from Oct 7, 2020

Conversation

medikoo
Copy link
Contributor

@medikoo medikoo commented Oct 7, 2020

Fixes regression introduced with #8319 (luckily not yet published) that brought back #7008 (as null properties got removed)

Additionally fixed test introduced with #8159 so it properly exposes eventual issue

@codecov-io
Copy link

Codecov Report

Merging #8353 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8353      +/-   ##
==========================================
+ Coverage   88.01%   88.02%   +0.01%     
==========================================
  Files         249      249              
  Lines        9309     9319      +10     
==========================================
+ Hits         8193     8203      +10     
  Misses       1116     1116              
Impacted Files Coverage Δ
lib/classes/ConfigSchemaHandler/index.js 90.09% <100.00%> (+0.98%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60cfa75...3c7f583. Read the comment docs.

@medikoo medikoo merged commit c93a799 into master Oct 7, 2020
@medikoo medikoo deleted the 1007-fix-null-handling branch October 7, 2020 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants