Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config Schema: Bring back non-array supported variants #8366

Merged
merged 1 commit into from Oct 8, 2020

Conversation

medikoo
Copy link
Contributor

@medikoo medikoo commented Oct 8, 2020

They were removed by mistake with #8319. It's only primitive/array combinations where singular variant should be removed. object/array should be left intact

Closes: #8365

They were removed by mistake with #8319.
It's only primitive/array combinations where singular variant should be removed. object/array should be left intact
@medikoo medikoo force-pushed the 1008-fix-mistakenly-removed-schemas branch from d8adc11 to 77482a3 Compare October 8, 2020 13:29
@codecov-io
Copy link

Codecov Report

Merging #8366 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8366   +/-   ##
=======================================
  Coverage   88.03%   88.03%           
=======================================
  Files         249      249           
  Lines        9267     9267           
=======================================
  Hits         8158     8158           
  Misses       1109     1109           
Impacted Files Coverage Δ
lib/plugins/aws/provider/awsProvider.js 93.06% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f235041...77482a3. Read the comment docs.

@medikoo medikoo merged commit 244ae11 into master Oct 8, 2020
@medikoo medikoo deleted the 1008-fix-mistakenly-removed-schemas branch October 8, 2020 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iamRoleStatements.Resource error on Fn::Join
2 participants