Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure to preserve "undefined" values properties when normalizing for schema #8374

Merged
merged 1 commit into from Oct 9, 2020

Conversation

medikoo
Copy link
Contributor

@medikoo medikoo commented Oct 9, 2020

Fixes issue introduced with #8319 where properties with undefined value were converted to null

Closes: #8370

@codecov-io
Copy link

Codecov Report

Merging #8374 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8374   +/-   ##
=======================================
  Coverage   88.03%   88.03%           
=======================================
  Files         249      249           
  Lines        9267     9268    +1     
=======================================
+ Hits         8158     8159    +1     
  Misses       1109     1109           
Impacted Files Coverage Δ
lib/classes/ConfigSchemaHandler/index.js 90.17% <100.00%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 244ae11...cf37cf4. Read the comment docs.

@medikoo medikoo merged commit 2e26e07 into master Oct 9, 2020
@medikoo medikoo deleted the 1009-fix-no-values-schema-normalization branch October 9, 2020 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: 'null' values are not allowed in templates since 2.5.0 for Condition/IpAddress
2 participants