Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config Schema: Revert invalid "oneOf" based validation #8376

Merged
merged 1 commit into from Oct 9, 2020

Conversation

medikoo
Copy link
Contributor

@medikoo medikoo commented Oct 9, 2020

Fixes issues introduced with: #8309, #8114 and #8230

Idea was to require few properties exchangeably but also allow not provide any of them at all, via:

{ "oneOf": [
  { "required": [] },
  { "required": ["foo"] },
  { "required": ["bar"] }, 
] }

That can't work, because if either foo or bar is provided, two schemas out of listed are matched, and that is invalid against one of rule.

Without using sophisticated not constructs there seems no way to reliably validate this by schema, therefore removed it/

Closes: #8373

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Config validation says provider.logs.restApi.role is required when roleManagedExternally=true
1 participant