Fix lodash for get #8378
Closed
Fix lodash for get #8378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
medikoo
suggested changes
Oct 12, 2020
There was a problem hiding this comment.
@Kishore-abhimanyu great thanks for an attempt on that.
Still CI exposed some issue with this proposal. Some introduced changes do not match Prettier formatting, and tests started to crash, and that's signal that something got broken
|
I also assume it's an attempt to replace |
|
Closing, due to lack activity. Still @Kishore-abhimanyu if you feel like continuing on it, let us know and I'll happily reopen |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for lodash get