New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aws provider apigateway schema #8383
Aws provider apigateway schema #8383
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8383 +/- ##
==========================================
- Coverage 88.02% 88.00% -0.02%
==========================================
Files 249 249
Lines 9278 9264 -14
==========================================
- Hits 8167 8153 -14
Misses 1111 1111
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @thewizarodofoz ! Looks really good, please see my remarks
limit: { type: 'integer' }, | ||
offset: { type: 'integer' }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'll be nice to restrict minimum to 0
additionalProperties: false, | ||
}, | ||
}, | ||
required: [], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's not add empty required
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @thewizarodofoz looks great! I've just commented on one last minor nuance, and we're ready to go!
burstLimit: { type: 'integer' }, | ||
rateLimit: { type: 'integer' }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's also put minimum: 0
on those
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @thewizarodofoz !
Closes: #8018