Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Replace _.set with native assignment #8709

Merged
merged 1 commit into from Jan 5, 2021

Conversation

fredericbarthelet
Copy link
Contributor

Addresses: #7747

@codecov
Copy link

codecov bot commented Jan 4, 2021

Codecov Report

Merging #8709 (54dda0f) into master (cf7b25e) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8709   +/-   ##
=======================================
  Coverage   87.29%   87.29%           
=======================================
  Files         256      256           
  Lines        9655     9655           
=======================================
  Hits         8428     8428           
  Misses       1227     1227           
Impacted Files Coverage Δ
lib/classes/PluginManager.js 96.62% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf7b25e...54dda0f. Read the comment docs.

Copy link
Contributor

@pgrzesik pgrzesik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @fredericbarthelet 🙇 Is the intention here to replace _.set usage only partially, where it's possible to replace it with native assignment? I see a few other uses of _.set which might be a bit more problematic

@fredericbarthelet
Copy link
Contributor Author

Hi @pgrzesik, indeed, those _.set are the "easy" one to replace. The rest is more problematic.

Copy link
Contributor

@pgrzesik pgrzesik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @fredericbarthelet 🙇

@pgrzesik pgrzesik changed the title Replace _.set with native property assignment statement refactor: Replace _.set with native assignment Jan 5, 2021
@pgrzesik pgrzesik merged commit 66aa66f into serverless:master Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants