Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Remove bluebird config #8732

Merged
merged 1 commit into from
Jan 10, 2021
Merged

CLI: Remove bluebird config #8732

merged 1 commit into from
Jan 10, 2021

Conversation

medikoo
Copy link
Contributor

@medikoo medikoo commented Jan 8, 2021

Fix regression, accidentally introduced with #8726 and exposed in integration tests run: https://github.com/serverless/serverless/runs/1669093528

Bluebird long stack trace config was moved after the point where eventual bluebird promises are created, and that's not allowed (observable only with SLS_DEBUG=1)

I decided to remove the config completely as we already migrated some parts from bluebird, so this functionality for sure no longer covers all async spans, and we're about to ditch bluebird with #7171

We're slowly migrating all code from it, so this functionality for sure no longer works as intended
@medikoo medikoo self-assigned this Jan 8, 2021
@codecov
Copy link

codecov bot commented Jan 8, 2021

Codecov Report

Merging #8732 (f4dd9a2) into master (847fa34) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8732   +/-   ##
=======================================
  Coverage   87.43%   87.43%           
=======================================
  Files         256      256           
  Lines        9631     9631           
=======================================
  Hits         8421     8421           
  Misses       1210     1210           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 847fa34...f4dd9a2. Read the comment docs.

@medikoo medikoo requested a review from pgrzesik January 8, 2021 15:14
Copy link
Contributor

@pgrzesik pgrzesik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@medikoo medikoo merged commit 1019e60 into master Jan 10, 2021
@medikoo medikoo deleted the 0108-remove-blubird-setup branch January 10, 2021 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants