New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add Sub
function example to pseudo parameters doc.
#8885
Conversation
Update documentation for change added in serverless#8279
Codecov Report
@@ Coverage Diff @@
## master #8885 +/- ##
==========================================
- Coverage 87.72% 87.69% -0.04%
==========================================
Files 266 266
Lines 9907 9907
==========================================
- Hits 8691 8688 -3
- Misses 1216 1219 +3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @walery, unfortunately I think the proposed example is misleading, as it's not going to be a valid part of serverless.yml
if that was the intention. Maybe it would be better to use something like
functions:
hello:
handler: my-function.handler
environment:
var: !Sub arn:aws:logs:${AWS::Region}:${AWS::AccountId}:log-group:/aws/lambda/*:*:*'
Please let me know what do you think 🙇
Yes, I thought about it as well. Then I decided to use the same example as above. Let me fix both examples 👍 |
Oh, I didn't notice that the example above is also wrong - if you could adjust them both that would be perfect. Thank you 🙇 |
The examples are now valid part of serverless. See serverless#8885 discussion.
I've now adjusted both examples. Thank you @pgrzesik |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome job @walery - thanks for not only expanding docs but also improving old misleading example 🙇
Sub
function example to pseudo parameters doc.
Update documentation for change added in #8279