Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove bluebird from lib/utils #8972

Merged
merged 2 commits into from
Feb 22, 2021

Conversation

juanjoDiaz
Copy link
Contributor

Addresses: #7171

I have few more areas asyncified in stashes in my local so I can keep submiting some of these.

@juanjoDiaz juanjoDiaz changed the title Remove bluebird utils Remove bluebird from utils Feb 19, 2021
@codecov
Copy link

codecov bot commented Feb 19, 2021

Codecov Report

Merging #8972 (b49b2d0) into master (36c78c7) will increase coverage by 0.02%.
The diff coverage is 95.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8972      +/-   ##
==========================================
+ Coverage   87.69%   87.72%   +0.02%     
==========================================
  Files         268      268              
  Lines       10050    10033      -17     
==========================================
- Hits         8813     8801      -12     
+ Misses       1237     1232       -5     
Impacted Files Coverage Δ
lib/utils/open.js 12.50% <66.66%> (-1.09%) ⬇️
lib/utils/createFromTemplate.js 95.00% <91.66%> (+11.66%) ⬆️
lib/utils/yamlAstParser.js 98.18% <96.42%> (+0.86%) ⬆️
lib/utils/downloadTemplateFromRepo.js 96.55% <98.00%> (-0.09%) ⬇️
lib/utils/fs/createZipFile.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36c78c7...0d862c5. Read the comment docs.

Copy link
Contributor

@pgrzesik pgrzesik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @juanjoDiaz 🙇 All the proposed changes look good 👍 It was planned to first address marking functions as async/await before moving to further refactor, but I think in this case it's okay and there's no need to block this PR. 👍

@pgrzesik pgrzesik changed the title Remove bluebird from utils refactor: Remove bluebird from lib/utils Feb 22, 2021
@pgrzesik pgrzesik merged commit 820cc1f into serverless:master Feb 22, 2021
@juanjoDiaz juanjoDiaz deleted the remove_bluebird_utils branch March 3, 2021 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants