Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove bluebird from lib/plugins/interactiveCli #9029

Conversation

juanjoDiaz
Copy link
Contributor

Addresses: #7171

@codecov
Copy link

codecov bot commented Feb 26, 2021

Codecov Report

Merging #9029 (e711f68) into master (2b4a9e4) will decrease coverage by 0.00%.
The diff coverage is 98.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9029      +/-   ##
==========================================
- Coverage   87.05%   87.04%   -0.01%     
==========================================
  Files         287      287              
  Lines       10994    10988       -6     
==========================================
- Hits         9571     9565       -6     
  Misses       1423     1423              
Impacted Files Coverage Δ
lib/plugins/interactiveCli/tabCompletion.js 97.29% <95.83%> (-0.21%) ⬇️
lib/plugins/interactiveCli/setupAws.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b4a9e4...c31382d. Read the comment docs.

@juanjoDiaz juanjoDiaz force-pushed the remove_bluebird_plugins_interactivecli branch from 11cc6db to c31382d Compare February 26, 2021 23:47
Copy link
Contributor

@pgrzesik pgrzesik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @juanjoDiaz 🙇

@pgrzesik pgrzesik merged commit 7c0ceb5 into serverless:master Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants