Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove bluebird from lib/plugins/aws #9054

Merged
merged 2 commits into from
Mar 3, 2021

Conversation

juanjoDiaz
Copy link
Contributor

Addresses: #7171

@codecov
Copy link

codecov bot commented Mar 2, 2021

Codecov Report

Merging #9054 (b2b566e) into master (d2e6a8a) will increase coverage by 0.09%.
The diff coverage is 90.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9054      +/-   ##
==========================================
+ Coverage   87.05%   87.15%   +0.09%     
==========================================
  Files         287      288       +1     
  Lines       10986    11020      +34     
==========================================
+ Hits         9564     9604      +40     
+ Misses       1422     1416       -6     
Impacted Files Coverage Δ
lib/configuration/variables/parse.js 100.00% <ø> (ø)
lib/plugins/aws/package/compile/functions.js 95.89% <ø> (-0.35%) ⬇️
lib/plugins/aws/rollbackFunction.js 88.23% <71.42%> (-11.77%) ⬇️
lib/Serverless.js 92.41% <75.00%> (-1.12%) ⬇️
scripts/serverless.js 84.81% <85.71%> (+10.69%) ⬆️
lib/plugins/aws/utils/credentials.js 94.44% <86.95%> (+2.50%) ⬆️
lib/plugins/aws/provider.js 95.14% <88.09%> (+0.28%) ⬆️
...n/variables/eventually-report-resolution-errors.js 100.00% <100.00%> (ø)
lib/configuration/variables/resolve.js 100.00% <100.00%> (ø)
lib/plugins/aws/metrics.js 100.00% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2e6a8a...df971fc. Read the comment docs.

@juanjoDiaz juanjoDiaz force-pushed the remove_bluebird_plugins_aws branch 2 times, most recently from 0f66ab5 to f87e23c Compare March 2, 2021 23:18
Copy link
Contributor

@pgrzesik pgrzesik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @juanjoDiaz - good job here 👍

@pgrzesik pgrzesik changed the title Remove bluebird plugins aws refactor: Remove bluebird from lib/plugins/aws Mar 3, 2021
@pgrzesik pgrzesik merged commit b11171c into serverless:master Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants