Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove bluebird from lib/plugins/aws/info #9068

Conversation

juanjoDiaz
Copy link
Contributor

Addesses: #7171

@codecov
Copy link

codecov bot commented Mar 3, 2021

Codecov Report

Merging #9068 (c58c720) into master (ccba70a) will decrease coverage by 0.01%.
The diff coverage is 94.73%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9068      +/-   ##
==========================================
- Coverage   87.15%   87.14%   -0.02%     
==========================================
  Files         288      288              
  Lines       11026    11017       -9     
==========================================
- Hits         9610     9601       -9     
  Misses       1416     1416              
Impacted Files Coverage Δ
lib/plugins/aws/info/getResourceCount.js 85.71% <80.00%> (-3.18%) ⬇️
lib/plugins/aws/info/getStackInfo.js 93.47% <93.75%> (-0.28%) ⬇️
lib/plugins/aws/info/getApiKeyValues.js 80.00% <100.00%> (-2.76%) ⬇️
lib/plugins/aws/info/index.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccba70a...3961d61. Read the comment docs.

@juanjoDiaz juanjoDiaz force-pushed the remove_bluebird_plugins_aws_info branch from bca3865 to 3961d61 Compare March 3, 2021 22:33
@pgrzesik
Copy link
Contributor

Thanks once again @juanjoDiaz - as mentioned in related PR, we'd like to follow more iterative, small-steps path - I'm going to close this PR for now.

@pgrzesik pgrzesik closed this Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants