fix(AWS API Gateway): Fix schema for apiKeys and permissionsBoundary
#9489
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9489 +/- ##
=======================================
Coverage 86.81% 86.81%
=======================================
Files 328 328
Lines 12029 12029
=======================================
Hits 10443 10443
Misses 1586 1586
Continue to review full report at Codecov.
|
| @@ -135,101 +136,79 @@ describe('#compileApiKeys()', () => { | |||
| ).to.equal('ApiGatewayDeploymentTest'); | |||
| }); | |||
| }); | |||
| }); | |||
|
|
|||
| describe('lib/plugins/aws/package/compile/events/apiGateway/lib/apiKeys.test.js', () => { | |||
There was a problem hiding this comment.
Let's move this out to a separate top-level describe block
There was a problem hiding this comment.
Hi @pgrzesik
I'm a bit confused, I think the describe('lib/plugins/aws/package/compile/events/apiGateway/lib/apiKeys.test.js' ... is already at the top-level. Am I misunderstanding what you mean?
Thanks
There was a problem hiding this comment.
Sorry - when reviewing I somehow saw it as nested in the #compileApiKeys describe, it's all good 👍
|
Closes #9440 |
pgrzesik
changed the title
apiKeys and permissionsBoundary
Updates schema to match existing implementation.
There was an existing test that already covered the apiKeys implementation which I refactored to use runServerless so that the schema is checked as well. I also added an extra test case to this for the case where neither name or value is provided, which were previously required fields in the schema (but not in the implementation).
Closes: #9080