Improve error reporting #9499
Merged
Improve error reporting #9499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
medikoo
force-pushed
the
0511-fix-user-error
branch
2 times, most recently
from
f0a13c6
to
1cfbc43
Compare
Codecov Report
@@ Coverage Diff @@
## master #9499 +/- ##
==========================================
- Coverage 86.83% 86.76% -0.08%
==========================================
Files 328 322 -6
Lines 12050 12033 -17
==========================================
- Hits 10464 10440 -24
- Misses 1586 1593 +7
Continue to review full report at Codecov.
|
pgrzesik
previously approved these changes
May 19, 2021
lib/classes/PluginManager.js
Outdated
| throw new ServerlessError( | ||
| `Custom variable resolver for ${variablePrefix} defined by ${pluginName} ` + | ||
| "specifies isDisabledAtPrepopulation but doesn't provide a string for a name", | ||
| 'USTOM_LEGACY_VARIABLES_RESOLVER_INVALID_CONFIGURATION' |
There was a problem hiding this comment.
There's C missing at the beginning of error code
| @@ -167,7 +169,7 @@ module.exports = async (exception, options = {}) => { | |||
| code: exception.code, | |||
| }; | |||
|
|
|||
| if (!isUserError || !exception.code) { | |||
| if (!isUserError || !exception.code || !isErrorCodeNormative(exception.code)) { | |||
There was a problem hiding this comment.
Great call with including location for such errors as well
medikoo
force-pushed
the
0511-fix-user-error
branch
from
1cfbc43
to
8057cca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With goal to improve specificity of error codes in telemetry reports
ServerlessErrorconstructor (otherwise they're assumed as programmer error)resourcesand crashing here on that, prevented failing with meaningful error message)ValidationErrorwhich was not perfectly clear where it comes from)sls statscommand