New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(AWS API Gateway): Ensure that method
depends on permission
#9609
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @nyamba, it looks good 👍 It would be, however, great to ensure that this functionality is covered by tests. The tests should land here: https://github.com/serverless/serverless/blob/master/test/unit/lib/plugins/aws/package/compile/events/apiGateway/lib/method/index.test.js and should use runServerless
@@ -20,6 +20,9 @@ module.exports = { | |||
}); | |||
} | |||
|
|||
const apiGetwayPermission = this.provider.naming.getLambdaApiGatewayPermissionLogicalId( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there's a small typo - apiGetway
should be apiGateway
Codecov Report
@@ Coverage Diff @@
## master #9609 +/- ##
==========================================
- Coverage 86.45% 86.16% -0.30%
==========================================
Files 321 321
Lines 12141 12161 +20
==========================================
- Hits 10497 10478 -19
- Misses 1644 1683 +39
Continue to review full report at Codecov.
|
Thanks @pgrzesik, pushed the improvements ;-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @nyamba - looks good overall, I only have small suggestions, please let me know what do you think 🙇
test/unit/lib/plugins/aws/package/compile/events/apiGateway/lib/method/index.test.js
Outdated
Show resolved
Hide resolved
test/unit/lib/plugins/aws/package/compile/events/apiGateway/lib/method/index.test.js
Outdated
Show resolved
Hide resolved
please check, @pgrzesik |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great changes, thank you @nyamba 🙇
method
depends on permission
Closes: #9525