Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Fix standalone detection on Windows #9648

Merged
merged 1 commit into from Jun 28, 2021

Conversation

medikoo
Copy link
Contributor

@medikoo medikoo commented Jun 28, 2021

Complementary fix to #9641

@codecov
Copy link

codecov bot commented Jun 28, 2021

Codecov Report

Merging #9648 (d6b4644) into master (70fb8b9) will not change coverage.
The diff coverage is 100.00%.

❗ Current head d6b4644 differs from pull request most recent head 254c4fd. Consider uploading reports for the commit 254c4fd to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9648   +/-   ##
=======================================
  Coverage   86.15%   86.15%           
=======================================
  Files         322      322           
  Lines       12181    12181           
=======================================
  Hits        10495    10495           
  Misses       1686     1686           
Impacted Files Coverage Δ
lib/utils/isStandaloneExecutable.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70fb8b9...254c4fd. Read the comment docs.

@medikoo medikoo requested a review from pgrzesik June 28, 2021 09:11
Copy link
Contributor

@pgrzesik pgrzesik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@medikoo medikoo merged commit 4bc8e2e into master Jun 28, 2021
@medikoo medikoo deleted the 0628-fix-standalone-detection-windows branch June 28, 2021 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants