Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS Local Invocation: Fix error handling of invalid file content #9667

Merged
merged 1 commit into from Jun 30, 2021

Conversation

medikoo
Copy link
Contributor

@medikoo medikoo commented Jun 30, 2021

Addressing error spotted in our telemetry reports

@codecov
Copy link

codecov bot commented Jun 30, 2021

Codecov Report

Merging #9667 (46b65bb) into master (ae5be0f) will decrease coverage by 0.00%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9667      +/-   ##
==========================================
- Coverage   86.14%   86.13%   -0.01%     
==========================================
  Files         326      326              
  Lines       12468    12471       +3     
==========================================
+ Hits        10740    10742       +2     
- Misses       1728     1729       +1     
Impacted Files Coverage Δ
lib/plugins/aws/invokeLocal/index.js 68.73% <75.00%> (-0.02%) ⬇️
lib/plugins/aws/provider.js 93.75% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae5be0f...46b65bb. Read the comment docs.

@medikoo medikoo requested a review from pgrzesik June 30, 2021 10:47
Copy link
Contributor

@pgrzesik pgrzesik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch 👍

@medikoo medikoo merged commit e836722 into master Jun 30, 2021
@medikoo medikoo deleted the 0630-improve-invoke-local-validation branch June 30, 2021 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants