Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Recognize --verbose option in info command #9695

Merged
merged 1 commit into from Jul 5, 2021

Conversation

medikoo
Copy link
Contributor

@medikoo medikoo commented Jul 5, 2021

This option wasn't documented as info command option, while internally is supported:

if (this.options.verbose) {

Closes: #9691

@medikoo medikoo self-assigned this Jul 5, 2021
@medikoo medikoo changed the title Recognize --verbose option in info command CLI: Recognize --verbose option in info command Jul 5, 2021
@codecov
Copy link

codecov bot commented Jul 5, 2021

Codecov Report

Merging #9695 (b916ae9) into master (cc24bc2) will not change coverage.
The diff coverage is n/a.

❗ Current head b916ae9 differs from pull request most recent head a2b2074. Consider uploading reports for the commit a2b2074 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9695   +/-   ##
=======================================
  Coverage   86.11%   86.11%           
=======================================
  Files         327      327           
  Lines       12512    12512           
=======================================
  Hits        10775    10775           
  Misses       1737     1737           
Impacted Files Coverage Δ
lib/cli/commands-schema/aws-service.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc24bc2...a2b2074. Read the comment docs.

@medikoo medikoo force-pushed the 0705-fix-verbose-visibility branch from 838cbea to a2b2074 Compare July 5, 2021 17:03
@medikoo medikoo requested a review from pgrzesik July 5, 2021 17:25
Copy link
Contributor

@pgrzesik pgrzesik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch 👍

@medikoo medikoo merged commit b124152 into master Jul 5, 2021
@medikoo medikoo deleted the 0705-fix-verbose-visibility branch July 5, 2021 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--verbose option unsupported warning for sls info
2 participants