fix(AWS Layers): Support references to external layers #9826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #9826 +/- ##
=======================================
Coverage 86.14% 86.14%
=======================================
Files 329 329
Lines 12808 12803 -5
=======================================
- Hits 11033 11029 -4
+ Misses 1775 1774 -1
Continue to review full report at Codecov.
|
medikoo
reviewed
Aug 11, 2021
| 'LAMBDA_LAYER_REFERENCE_NOT_FOUND' | ||
| ); | ||
| if (process.env.SLS_DEBUG) { | ||
| serverless.cli.log( |
There was a problem hiding this comment.
It would be better to rely on @serverless/utils/log
We're rather on the path on removing dependency on serverless instance.
There was a problem hiding this comment.
of course, great suggestion 👍
pgrzesik
force-pushed
the
support-references-to-external-layers
branch
from
b0c53c2
to
ca0656f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #9797
This fix will not error out if layer referenced by
Refwill not be found locally, but rather allow such behavior and let the deployment fail is the layer really cannot be referenced.