Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Replace _.pick with native property assignment #9937

Merged
merged 1 commit into from Sep 13, 2021

Conversation

JonasMatos0
Copy link
Contributor

Addresses: #7747

Copy link
Contributor

@pgrzesik pgrzesik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @JonasMatos0 - there are some tests failing, could you please take a look at it?

@JonasMatos0
Copy link
Contributor Author

I see, @pgrzesik . I didn't think there were scenarios in which these fields were falsey.
The code has been updated. Could you please re-review?

Thanks!

@codecov
Copy link

codecov bot commented Sep 10, 2021

Codecov Report

Merging #9937 (b95424d) into master (5c9766c) will decrease coverage by 0.10%.
The diff coverage is 90.19%.

❗ Current head b95424d differs from pull request most recent head 6da58cf. Consider uploading reports for the commit 6da58cf to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9937      +/-   ##
==========================================
- Coverage   86.30%   86.19%   -0.11%     
==========================================
  Files         330      330              
  Lines       12923    13002      +79     
==========================================
+ Hits        11153    11207      +54     
- Misses       1770     1795      +25     
Impacted Files Coverage Δ
lib/plugins/aws/invokeLocal/index.js 68.81% <0.00%> (ø)
lib/plugins/deploy.js 94.73% <ø> (ø)
lib/plugins/aws/deploy/lib/extendedValidate.js 95.23% <50.00%> (-4.77%) ⬇️
lib/plugins/aws/deploy/lib/uploadArtifacts.js 91.39% <81.81%> (+1.92%) ⬆️
lib/plugins/aws/deploy/index.js 96.36% <83.33%> (-3.64%) ⬇️
lib/plugins/aws/info/display.js 77.14% <83.33%> (-14.94%) ⬇️
lib/plugins/aws/lib/monitorStack.js 94.56% <87.50%> (-2.88%) ⬇️
lib/cli/handle-error.js 88.54% <100.00%> (+0.62%) ⬆️
lib/configuration/read.js 83.56% <100.00%> (ø)
lib/configuration/variables/sources/file.js 100.00% <100.00%> (ø)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c9766c...6da58cf. Read the comment docs.

lib/plugins/aws/info/getApiKeyValues.js Outdated Show resolved Hide resolved
@pgrzesik pgrzesik changed the title Replace _.pick with native property assignment statement refactor: Replace _.pick with native property assignment Sep 13, 2021
@pgrzesik pgrzesik merged commit 6087fa3 into serverless:master Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants