Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace _.capitalize with native property #9975

Closed
wants to merge 1 commit into from
Closed

Replace _.capitalize with native property #9975

wants to merge 1 commit into from

Conversation

JonasMatos0
Copy link
Contributor

Addresses: #7747

medikoo
medikoo reviewed Sep 20, 2021
View reviewed changes
Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JonasMatos0 great thanks for this PR. Still, we didn't intend to replace _.capitalize (as there's no native counterpart)

I believe it's better to stick to lodash in this case

@JonasMatos0
Copy link
Contributor Author

Ok, @medikoo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medikoo medikoo medikoo left review comments

Assignees

@JonasMatos0 JonasMatos0

Labels
question
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JonasMatos0 @medikoo