New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Remove dependency on obsolete archive-type
#186
base: main
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## main #186 +/- ##
==========================================
+ Coverage 89.32% 89.37% +0.04%
==========================================
Files 27 27
Lines 731 734 +3
==========================================
+ Hits 653 656 +3
Misses 78 78
Continue to review full report at Codecov.
|
@@ -18,7 +18,6 @@ const fsp = require('fs').promises; | |||
const path = require('path'); | |||
const { URL } = require('url'); | |||
const contentDisposition = require('content-disposition'); | |||
const archiveType = require('archive-type'); | |||
const decompress = require('decompress'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also suffers from the same issue. See the log from my report
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've just noticed that, replacing this is going to be a bit bigger problem, thanks for pointing that out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup fair enough. I think you can do another PR for that one when you find an alternative or fork
Has there been any progress on this issue? |
@pgrzesik sorry, I know it's been a while, but do you remember why it was marked as draft and not pushed forward after all? |
The problem is that both |
Closes: #185