Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade make-dir to 4.0.0 #213

Merged
merged 1 commit into from
Jun 29, 2023
Merged

Upgrade make-dir to 4.0.0 #213

merged 1 commit into from
Jun 29, 2023

Conversation

brianlenz
Copy link
Contributor

  • Upgraded make-dir to 4.0.0 to address security vulnerability with semver.

fixes #212

* Upgraded `make-dir` to `4.0.0` to address security vulnerability with `semver`.

fixes #212
@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (98db4a0) 89.71% compared to head (218ce44) 89.71%.

❗ Current head 218ce44 differs from pull request most recent head 9775ac0. Consider uploading reports for the commit 9775ac0 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #213   +/-   ##
=======================================
  Coverage   89.71%   89.71%           
=======================================
  Files          28       28           
  Lines         836      836           
=======================================
  Hits          750      750           
  Misses         86       86           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @brianlenz

It's safe to update make-dir v4 as it just drops support for Node.js versions below v10, while this package already requires v12 as minimum

@medikoo medikoo merged commit 8767882 into serverless:main Jun 29, 2023
4 checks passed
@brianlenz brianlenz deleted the update_make-dir_4.0.0 branch June 29, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Security Vulnerability with semver (via make-dir Transitive Dependency)
2 participants