Added test for servo#353 and fixed use after free bug that causes it #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took a look at what was causing #353.
Turns out the
push_heapfunction was placing the heap pointer into a local variable before callingself.reserve(). reserve in turn callsrealloc()- which can free the old heap allocation & create a new one. When this happens, the oldptris becomes invalid.The code was writing to this invalid pointer (
ptr.as_ptr().add(len).write(value)) - which is a use-after-free bug.This PR fixes the bug and adds a regression test.