New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow mutating <input disabled type=checkbox/radio> #27666
Allow mutating <input disabled type=checkbox/radio> #27666
Conversation
if !self.is_mutable() && | ||
self.input_type() != InputType::Checkbox && | ||
self.input_type() != InputType::Radio | ||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on https://html.spec.whatwg.org/multipage/input.html#the-input-element:legacy-pre-activation-behavior it looks like this entire check can be removed instead.
if !self.is_mutable() && | ||
self.input_type() != InputType::Checkbox && | ||
self.input_type() != InputType::Radio | ||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can remove this check as well.
@bors-servo r+ |
📌 Commit 15376d0 has been approved by |
Allow mutating <input disabled type=checkbox/radio> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #27586 <!-- Either: --> - [X] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
💔 Test failed - status-taskcluster |
@bors-servo retry
|
☀️ Test successful - status-taskcluster |
./mach build -d
does not report any errors./mach test-tidy
does not report any errors