Implement recreate_context for WebGPU canvas and fix handle_wgpu_msg crash #30386
Conversation
If those tests use iframes to trigger media query changes, note that all iframe media query tests are incredibly flaky and brittle because of Servo's loose implementation of iframe loading order. |
|
When based on #30406 there is no error on wgpu examples. But when refreshed examples do not work (also non-ui wgpu examples), maybe that's has something to do with wasm loading as pure JS examples work normally on refresh too. |
This comment was marked as resolved.
This comment was marked as resolved.
sagudev
changed the title
|
Resize canvas example from webgpu-samples still crash, but that is not problem with |
| canvas: HTMLCanvasElementOrOffscreenCanvas, | ||
| #[ignore_malloc_size_of = "manual writing is hard"] | ||
| /// <https://gpuweb.github.io/gpuweb/#dom-gpucanvascontext-configuration-slot> | ||
| config: RefCell<Option<GPUCanvasConfiguration>>, |
There was a problem hiding this comment.
Is the configuration ever read other than to know whether to reconfigure the context? Why not just store a bool?
There was a problem hiding this comment.
It's only for reconfigure AFAIK.
| if let Some(config) = self.config.take() { | ||
| self.Configure(&config) | ||
| } |
There was a problem hiding this comment.
Why isn't the call Unconfigure() here instead of in Configure()?
There was a problem hiding this comment.
That's how it was done in mozilla, but I will recheck specs tomorrow.
mrobinson
changed the title
|
I will need to rethink this, so I spitted off crash fix. |
This makes wgpu examples work.
Depends on #30406. DONECurrent state of webgpu examples
Works on reload:
Does not work on reload (but works on freshly opened servo; see #30417):
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors