servoshell: add fullscreen option #30614
Conversation
|
🔨 Triggering try run (#6846095678) with platforms=windows and layout=none |
There was a problem hiding this comment.
Thanks for the patch!
I think fullscreen generally means not having any window decorations, not just maximised. We should also return whether we started in fullscreen in the Window.fullscreen of our return value.
You can use WindowBuilder::with_fullscreen or winit Window::set_fullscreen for this, or even better, call .set_fullscreen(true) on our headed Window before returning it.
|
✨ Try run (#6846095678) succeeded. |
MarybethGasman
force-pushed
the
feat/cli-fullscreen-option
branch
from
e58e4ab
to
6cd0f48
Compare
|
Appreciate your advice. It works as expected when launching. When I refresh page, the web content seems not displayed in fullscreen mode. And I can't exit fullscreen mode or servo by Esc. The Esc problem is because fullscreen is a whatwg web api. The web content not in fullscreen problem is solved by call .with_maximized on the window builder. |
ports/servoshell/headed_window.rs
Outdated
| @@ -139,7 +142,7 @@ impl Window { | |||
| .expect("Failed to create WR surfman"); | |||
|
|
|||
| debug!("Created window {:?}", winit_window.id()); | |||
| Window { | |||
| let window = Window { | |||
These changes add a cli option to start servo in fullscreen mode. As requested in #30599.
It is currently in draft form as we need to have further discussions to determine whether we truly need it.
No tests for now.