Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --with-asan option #31429

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add --with-asan option #31429

wants to merge 1 commit into from

Conversation

sagudev
Copy link
Member

@sagudev sagudev commented Feb 26, 2024

Based on #27474, but if finding binary fails in /target/{profile}
it fallback to /target/{target}/{profile}/servo or you can provide --with-asan to commands for direct binary finding.


  • There are tests for these changes OR
  • These changes do not require tests because ___

@sagudev sagudev marked this pull request as ready for review February 26, 2024 19:03
python/servo/build_commands.py Show resolved Hide resolved
python/servo/build_commands.py Outdated Show resolved Hide resolved
python/servo/build_commands.py Show resolved Hide resolved
python/servo/command_base.py Outdated Show resolved Hide resolved
python/servo/platform/base.py Outdated Show resolved Hide resolved
@sagudev
Copy link
Member Author

sagudev commented Feb 28, 2024

Now that #31441 landed I plan to add mach bootstrap-nightly-rust for ASan needs.

@sagudev sagudev changed the title Add AddressSanitizers option and unify nightly rust versions Add AddressSanitizers option and corresponding nightly rust version Feb 28, 2024
@sagudev
Copy link
Member Author

sagudev commented Mar 1, 2024

@mrobinson could we push this forward?

Copy link
Member

@jdm jdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

@sagudev sagudev marked this pull request as draft March 10, 2024 17:43
@sagudev
Copy link
Member Author

sagudev commented Mar 10, 2024

Copy trick does not work on mac (due to otool and gstreamer), so I guess we need to do this in right, but more complicated way or introduce even more hacks.

@sagudev sagudev marked this pull request as ready for review March 12, 2024 08:18
@sagudev sagudev changed the title Add AddressSanitizers option and corresponding nightly rust version Add --with-asan option May 3, 2024
@sagudev sagudev mentioned this pull request May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants