-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
webgpu: Use WGPU poller thread for poll_all_devices #32266
Conversation
Timings are more sane now (we actually outperform firefox on onSubmittedWorkDone tests due to https://bugzilla.mozilla.org/show_bug.cgi?id=1870699): EDIT: According to measurements on my computer we are also faster than chromium (edge) on onSubmittedWorkDone tests (tested edge vs. servo on my win11 machine). |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
This is required to fix some deadlocks.
Some flakes that do occur but rarely (sometimes they are stable, other times they simply do not happen):
(this is actually our fault as we do not handle this situation).
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with some nits and perhaps one refactoring.
File an issue for this one? Seems like we can catch the destroy error and send an error back to script? |
Done #32277 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…bgpu) {"fail_fast": false, "matrix": [{"name": "WebGPU CTS", "workflow": "linux", "wpt_layout": "2020", "profile": "production", "unit_tests": false, "wpt_tests_to_run": "_webgpu"}]}
As discussed https://servo.zulipchat.com/#narrow/stream/263398-general/topic/ipc_channel, firefox will also switch to something similar in the future: https://bugzilla.mozilla.org/show_bug.cgi?id=1870699.
In future we could make thread per device, but that would require hashmap for Pollers.
Fastgame still works: https://sagudev.github.io/briefcase/fastgame.html
try run: https://github.com/sagudev/servo/actions/runs/9051091523/job/24867638272
./mach build -d
does not report any errors./mach test-tidy
does not report any errors