Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some simple clippy lints #284

Merged
merged 10 commits into from
Apr 21, 2024
Merged

Fix some simple clippy lints #284

merged 10 commits into from
Apr 21, 2024

Conversation

jschwe
Copy link
Contributor

@jschwe jschwe commented Apr 21, 2024

Each lint was fixed in an individual commit, for easier review.

After this PR clippy is warning free when run on surfman, examples are excluded and the following lints are allowed:

  • clippy::missing_safety_doc
  • clippy::unnecessary_cast
  • clippy::result_large_err
  • clippy::mismatched_target_os
  • clippy::unnecessary_mut_passed
  • clippy::drop_non_drop

Copy link
Member

@mrobinson mrobinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would also be nice to add a clippy run to GitHub Actions to ensure that these don't regress.

Copy link
Member

@mrobinson mrobinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a cargo fmt run, I think.

auto-merge was automatically disabled April 21, 2024 14:53

Head branch was pushed to by a user without write access

@jschwe
Copy link
Contributor Author

jschwe commented Apr 21, 2024

It would also be nice to add a clippy run to GitHub Actions to ensure that these don't regress.

I agree - but I think the examples need to be fixed first (they are not compiling, and cause clippy to fail). Locally, I just ignored the issue by deleted the examples folder.

@mrobinson mrobinson added this pull request to the merge queue Apr 21, 2024
Merged via the queue into servo:main with commit 0a55a6a Apr 21, 2024
16 checks passed
@jschwe jschwe deleted the jschwender/clippy branch April 21, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants