Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade serde #2577

Merged
merged 1 commit into from Mar 27, 2018
Merged

Upgrade serde #2577

merged 1 commit into from Mar 27, 2018

Conversation

SimonSapin
Copy link
Member

@SimonSapin SimonSapin commented Mar 27, 2018

This will enable using serde-rs/serde#1191 in Servo

Includes a rebase of serde-rs/serde@master...Gankro:deserialize_from_enums4


This change is Reviewable

@SimonSapin
Copy link
Member Author

@bors-servo try

@bors-servo
Copy link
Contributor

⌛ Trying commit 734822b with merge 497dd30...

bors-servo pushed a commit that referenced this pull request Mar 27, 2018
WIP: Upgrade serde

This will enable using serde-rs/serde#1191 in Servo

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2577)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - status-taskcluster

@SimonSapin
Copy link
Member Author

The log ends as below. Does this mean Cargo is missing?

tidy reported no errors.
Traceback (most recent call last):
  File "script/headless.py", line 68, in <module>
    subprocess.check_call(['cargo', 'build', '--release', '--verbose', '--features', 'headless'])
  File "/usr/lib/python2.7/subprocess.py", line 536, in check_call
    retcode = call(*popenargs, **kwargs)
  File "/usr/lib/python2.7/subprocess.py", line 523, in call
    return Popen(*popenargs, **kwargs).wait()
  File "/usr/lib/python2.7/subprocess.py", line 711, in __init__
    errread, errwrite)
  File "/usr/lib/python2.7/subprocess.py", line 1343, in _execute_child
    raise child_exception
OSError: [Errno 2] No such file or directory
[taskcluster 2018-03-27 09:05:04.829Z] === Task Finished ===
[taskcluster 2018-03-27 09:05:04.829Z] Unsuccessful task run with exit code: 1 completed in 389.522 seconds

@glennw
Copy link
Member

glennw commented Mar 27, 2018

The log also contains:

curl: (7) Failed to connect to sh.rustup.rs port 443: Connection timed out

@glennw
Copy link
Member

glennw commented Mar 27, 2018

So, I guess a temporary network failure?

@SimonSapin
Copy link
Member Author

Ah thanks, I’d missed that.

@bors-servo try retry

@bors-servo
Copy link
Contributor

⌛ Trying commit 734822b with merge 1a12a10...

bors-servo pushed a commit that referenced this pull request Mar 27, 2018
WIP: Upgrade serde

This will enable using serde-rs/serde#1191 in Servo

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2577)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - status-appveyor, status-taskcluster
State: approved= try=True

@SimonSapin SimonSapin changed the title WIP: Upgrade serde Upgrade serde Mar 27, 2018
@emilio
Copy link
Member

emilio commented Mar 27, 2018

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 1669ec2 has been approved by emilio

@bors-servo
Copy link
Contributor

⌛ Testing commit 1669ec2 with merge 7ef6084...

bors-servo pushed a commit that referenced this pull request Mar 27, 2018
Upgrade serde

This will enable using serde-rs/serde#1191 in Servo

Includes a rebase of serde-rs/serde@master...Gankro:deserialize_from_enums4

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2577)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - status-taskcluster

This will enable using serde-rs/serde#1191 in Servo

This includes a rebase of serde-rs/serde@master...Gankro:deserialize_from_enums4
@SimonSapin
Copy link
Member Author

Cloning into 'webrender'...
fatal: reference is not a tree: 7ef6084e3615f389de876f1bf1954de797182bbe

@bors-servo r=emilio

@bors-servo
Copy link
Contributor

📌 Commit beebcd9 has been approved by emilio

@bors-servo
Copy link
Contributor

⌛ Testing commit beebcd9 with merge 97a39b3...

bors-servo pushed a commit that referenced this pull request Mar 27, 2018
Upgrade serde

This will enable using serde-rs/serde#1191 in Servo

Includes a rebase of serde-rs/serde@master...Gankro:deserialize_from_enums4

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2577)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - status-appveyor, status-taskcluster
Approved by: emilio
Pushing 97a39b3 to master...

@bors-servo bors-servo merged commit beebcd9 into master Mar 27, 2018
@SimonSapin SimonSapin deleted the serdeup branch March 27, 2018 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants