Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notempty #107

Closed
wants to merge 1 commit into from
Closed

Add notempty #107

wants to merge 1 commit into from

Conversation

redixin
Copy link

@redixin redixin commented May 8, 2024

Add notempty parameter. Pretty much the same as required but also check if value is empty string.

@sethvargo
Copy link
Owner

Duplicate of #44

@sethvargo sethvargo marked this as a duplicate of #44 May 8, 2024
@sethvargo sethvargo closed this May 8, 2024
@redixin
Copy link
Author

redixin commented May 10, 2024

Have read the thread. I agree that empty variables is a kind of misconfigurations or bugs in some scripts, and that's why we have required tag. We have this tag to detect misconfiguration and fail early.
Currently we use additional validation for such cases, but I guess we will just use another library to parse envs

@sethvargo
Copy link
Owner

Sounds great, thanks! Glad to hear you have a path forward 😄.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants