Change custom unmarshaling order #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gust1n
force-pushed
the
main
branch
2 times, most recently
from
a4cbcaf
to
683dd0a
Compare
Since the input parsed by envconfig is most often configuration written by humans, it makes sense to test unmarshaling as text before any other formats. Also JSON should be more common than binary, so this commits sets the order to: 1. envconfig.Decoder 2. encoding.TextUnmarshaler 3. json.Unmarshaler 4. encoding.BinaryUnmarshaler 5. gob.GobDecoder and adds tests to very that order. Closes sethvargo#58.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the input parsed by envconfig is most often configuration written
by humans, it makes sense to test unmarshaling as text before any other
formats. Also JSON should be more common than binary, so this commits
sets the order to:
and adds tests to very that order. Closes #58.